Make the macOS display configuration also change display mode #55260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
DanielRyanSmith,
foolip,
jgraham,
jonathan-j-lee and
past
gsnedders
force-pushed
the
macos-display-configuration
branch
from
8659036 to
c62eb27
Compare
gsnedders
force-pushed
the
macos-display-configuration
branch
from
c62eb27 to
d2534b2
Compare
JonWBedard
approved these changes
Oct 13, 2025
This renames the `macos-color-profile` command to `macos-display-configuration` (as it is a CI command, it is reasonable to believe this is safe), and expands its scope. Along with color space, we now also attempt to make the smallest change possible to the display mode such that we end up on a 1x display mode.
gsnedders
force-pushed
the
macos-display-configuration
branch
from
d2534b2 to
9438534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
macos-color-profilecommand tomacos-display-configuration(as it is a CI command, it is reasonable to believe this is safe), and expands its scope.Along with color space, we now also attempt to make the smallest change possible to the display mode such that we end up on a 1x display mode.
There's a potential future where we make these changes within wptrunner (though like
--kill-safari, behind a flag), especially if we start adding support for running tests at specific DPI.