-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Classifies web features from "window-controls-overlay" to "webxr-hit-test" #55663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f7d3aea
dc145d9
cbc31f2
b26f616
29f364e
5aba07a
d28f011
63dfdae
37ccf70
7f3d1db
67e17d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: window-controls-overlay | ||
| files: | ||
| - '*window-controls-overlay*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - '*width*' | ||
| - '*height*' | ||
| - '*blockw*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - anonymous-boxes-001.xht |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - '*width*' | ||
| - '*height*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - page-container-000.xht | ||
| - page-container-002.xht | ||
| - page-container-004.xht | ||
| - page-container-010.xht |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: widows-orphans | ||
| files: | ||
| - 'orphans-*' | ||
| - 'widows-*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - '*width*' | ||
| - '*height*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: white-space | ||
| files: | ||
| - text-align-white-space-* | ||
| - white-space-* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - height-*.xht |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - 'width-*' | ||
| - 'height-*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - percentage-height-replaced-content-in-auto-cb.html |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - 'width-*' | ||
| - 'height-*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - 'width-*' | ||
| - 'height-*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: will-change | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,9 @@ features: | |
| files: | ||
| - user-invalid.html | ||
| - user-valid.html | ||
| - name: where | ||
| files: | ||
| - is-where-* | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also tests I think that for now it's best to treat mapping of |
||
| - is-default-ns-* | ||
| - not-default-ns-* | ||
| - pseudo-where-crash.html | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,7 @@ features: | |
| - name: state | ||
| files: | ||
| - state-in-has.html | ||
| - name: where | ||
| files: | ||
| - is-where-* | ||
| - where.html | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,3 +15,7 @@ features: | |
| - name: not | ||
| files: | ||
| - parse-not.html | ||
| - name: where | ||
| files: | ||
| - parse-is-where.html | ||
| - parse-where.html | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: where | ||
| files: | ||
| - query-where.html |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: wheel-events | ||
| files: | ||
| - Event-subclasses-constructors.html | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This tests many other events as well and can't be mapped to any feature. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| features: | ||
| - name: wheel-events | ||
| files: | ||
| - non-passive-mousewheel-event-listener-* | ||
| - non-passive-wheel-event-listener-* | ||
| - passive-mousewheel-event-listener-* | ||
| - passive-wheel-event-listener-* | ||
| - synthetic-events-cancelable.html | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test is for other events as well and can't be mapped to any feature. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,6 @@ features: | |
| - name: scrollend | ||
| files: | ||
| - scrollend-* | ||
| - name: wheel-events | ||
| files: | ||
| - wheel-event-transactions-* | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: window | ||
| files: | ||
| - '*' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: window | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: window | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: window | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: window | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: width-height | ||
| files: | ||
| - sizing-properties-computed.svg |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: white-space | ||
| files: | ||
| - text-multiline-* | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirmed that this is right despite the filenames not being close, the tests are for https://svgwg.org/svg2-draft/text.html#TextLayoutPreMultiline |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| features: | ||
| - name: wheel-events | ||
| files: | ||
| - historical.html | ||
| - idlharness.window.js |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: wheel-events | ||
| files: | ||
| - WheelEvent.* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| features: | ||
| - name: wheel-events | ||
| files: | ||
| - wheel-* |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: webxr-hit-test | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: webxr-layers | ||
| files: '**' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| features: | ||
| - name: webxr-lighting-estimation | ||
| files: '**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be simpler (more maintainable) to include "*" and exclude the things that shouldn't be mapped here? (It's a real question, I can't tell exactly what's being left out by these patterns, so I'm not sure.)