Paint transition pseudos on top of everything else in the scope. #56189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7178180
branch
from
d743d7d to
cb6986b
Compare
Since crrev.com/1546589, the ::view-transition pseudo's PaintLayer is a child of the scope's PaintLayer. This patch implements custom paint order logic to ensure that the pseudo tree behaves like an overlay, regardless of any higher z-index that may be set on the scope's non-participating descendants. Also test the crash repro from https://crbug.com/445406431#comment3 (self-participating scope with high z-index child also participating). Bug: 421927605, 445406431 Change-Id: Ifac38969abbb82ea9a4ca67e6b03fffe99d52044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7178180 Commit-Queue: Steve Kobes <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1549132}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7178180
branch
from
cb6986b to
185ef53
Compare
wpt-pr-bot
approved these changes
Nov 24, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since crrev.com/1546589, the ::view-transition pseudo's PaintLayer is a
child of the scope's PaintLayer.
This patch implements custom paint order logic to ensure that the
pseudo tree behaves like an overlay, regardless of any higher z-index
that may be set on the scope's non-participating descendants.
Also test the crash repro from https://crbug.com/445406431#comment3
(self-participating scope with high z-index child also participating).
Bug: 421927605, 445406431
Change-Id: Ifac38969abbb82ea9a4ca67e6b03fffe99d52044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7178180
Commit-Queue: Steve Kobes <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1549132}