Use EqualIgnoringAsciiCase() in LookupAlgorithmIdByName()#58271
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 5, 2026
Merged
Use EqualIgnoringAsciiCase() in LookupAlgorithmIdByName()#58271chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
The "Normalizing an algorithm" algorithm[1] says that names should be matched ASCII case-insensitive [2]. Currently the lookup sort of does that, but the verifying comparison still uses a full Unicode case-folding comparison. Because of how the lookup is structured the lookup for some algorithm names could still accept non-ASCII. Replace the final DeprecatedEqualIgnoringCase() comparison with EqualIgnoringAsciiCase(). [1] https://w3c.github.io/webcrypto/#algorithm-normalization-normalize-an-algorithm [2] https://w3c.github.io/webcrypto/#case-insensitive Bug: 40476285 Change-Id: If1ee6a3c1e75f271c171b44f8de31fe688546b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7633022 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1594550}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7633022
branch
from
571a5ee to
c090cf7
Compare
wpt-pr-bot
approved these changes
Mar 5, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Normalizing an algorithm" algorithm[1] says that names should be
matched ASCII case-insensitive [2]. Currently the lookup sort of does
that, but the verifying comparison still uses a full Unicode
case-folding comparison. Because of how the lookup is structured the
lookup for some algorithm names could still accept non-ASCII.
Replace the final DeprecatedEqualIgnoringCase() comparison with
EqualIgnoringAsciiCase().
[1] https://w3c.github.io/webcrypto/#algorithm-normalization-normalize-an-algorithm
[2] https://w3c.github.io/webcrypto/#case-insensitive
Bug: 40476285
Change-Id: If1ee6a3c1e75f271c171b44f8de31fe688546b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7633022
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1594550}