Fix private VAPID key padding when importing from PEM #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
In 9.0.2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code pads the private key until it reaches a length of 2 * PRIVATE_KEY_LENGTH, which is 64, however, below, there is a condition that ensure that the length of said private key is PRIVATE_KEY_LENGTH, which will always fail when the private was set by importing a PEM due to it being left padded too much.
I have removed the unnecessary padding.
Here is a video of showing it working properly:
https://github.com/user-attachments/assets/3d5610e3-faed-408d-8472-6452664f00ad