[BUGFIX] Re-enable b13/container translation #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beside a quite big testing setup, the extension did not test basic page translations and translation tests with b13/container activated. Due to this lack of missing translation tests, issues where encountered, which could be avoided if tests where given. This commit adds tests for three things: 1. Basic page translation 2. Translation of added l10n_mode fields 3. Translation of content elements inside b13/container
With the behaviour change of our translations using an own DataHandler command, the b13/container hooks weren't able to detect their respective inline content elements. With this change the class override for containers CommandMapPostProcessingHook is refactored. Two chaned where done: 1. add own `processCmdmap_postProcess` method checking for our internal translation 2. validate the need of the old `localizeOrCopyToLanguage` method not longer needed and remove The Test added before validates, the method is no longer needed and therefore a removal is provided avoiding issues with changed code in original class. The `processCmdmap_postProcess` method only checks for internal DataHandler command and if not executed, calls the parent method keeping behaviour unchanged.
calien666
force-pushed
the
bugfix/issue-434
branch
from
e71f21f to
a46a441
Compare
sbuerk
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434