[TASK] Remove obsolete f:replace from partial #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently merged pull-request #429 to solve page settings translation provided two changes which fixes the same issue in two different ways by providing the correct DataHandler command name in the url. Only one is needed and allows to drop the not so nice `f:replace()` ViewHelper usage within the partial and keeping the working state. Replace ViewHelper is now removed again and minor code cleanup (outcommented code) done in the same step. Related: #429 (#428) da13ab1
calien666
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently merged pull-request #429 to solve page
settings translation provided two changes which
fixes the same issue in two different ways by
providing the correct DataHandler command name
in the url.
Only one is needed and allows to drop the not
so nice
f:replace()ViewHelper usage withinthe partial and keeping the working state.
Replace ViewHelper is now removed again and
minor code cleanup (outcommented code) done
in the same step.
Related: #429 (#428) da13ab1