feat(tests): add Mega + Orion integration tests with Qlean#2012
feat(tests): add Mega + Orion integration tests with Qlean#2012benjamin-747 merged 2 commits intoweb3infra-foundation:mainfrom
Conversation
Signed-off-by: miliu2cc <miliu2cc@gmail.com>
Signed-off-by: miliu2cc <miliu2cc@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3e2e3ec3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let build_success = logs.lines().any(|line| { | ||
| line.to_lowercase().contains("build") | ||
| && (line.to_lowercase().contains("completed") | ||
| || line.to_lowercase().contains("finished")) | ||
| && line.contains("exit code: Some(0)") | ||
| }); |
There was a problem hiding this comment.
The success predicate accepts any line in the last 200 Orion logs containing build + completed/finished + exit code: Some(0), but it is not correlated with the trigger just submitted. Because earlier pushes in this test can already produce successful build records, this can mark the E2E test as passed even when the manual trigger under test fails.
Useful? React with 👍 / 👎.
| tracing_subscriber::fmt() | ||
| .with_env_filter(EnvFilter::from_default_env()) | ||
| .init(); |
There was a problem hiding this comment.
init_tracing() calls tracing_subscriber::fmt().init(), which panics if a global subscriber is already set. Since both ignored tests call this function, running the ignored suite together can fail before test logic executes; using try_init or a one-time guard avoids this cross-test panic.
Useful? React with 👍 / 👎.
eef772a
2 participants
No description provided.