Skip to content

chore(orion): tune buck2 and scorpio config#2016

Merged
benjamin-747 merged 1 commit intoweb3infra-foundation:mainfrom
Ivanbeethoven:main
Mar 13, 2026
Merged

chore(orion): tune buck2 and scorpio config#2016
benjamin-747 merged 1 commit intoweb3infra-foundation:mainfrom
Ivanbeethoven:main

Conversation

@Ivanbeethoven
Copy link
Copy Markdown
Collaborator

  • Add BUCKD_STARTUP_TIMEOUT=30 and BUCKD_STARTUP_INIT_TIMEOUT to all buck2 command invocations (Buck2::command, get_repo_targets, build) to prevent daemon startup timeouts under slow I/O environments
  • Bump scorpiofs dependency from 0.1.1 to 0.2.0
  • Increase scorpio load_dir_depth from 3 to 5 and fetch_file_thread from 10 to 20 for better prefetch coverage and concurrency

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9fe90152d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// at target level (e.g. pending / running / succeeded / failed).
cmd.args([
cmd.env("BUCKD_STARTUP_TIMEOUT", "30")
.env("BUCKD_STARTUP_INIT_TIMEOUT", "120")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use consistent buckd init timeout in build command

The build path now sets BUCKD_STARTUP_INIT_TIMEOUT to 120, while the other buck2 entry points in this same change use 1200; in slow I/O environments where buckd initialization takes longer than 2 minutes but less than 20 minutes, build will still fail with startup timeouts even though target discovery succeeds. This inconsistency in build undermines the stated timeout hardening and can cause task builds to fail intermittently under load.

Useful? React with 👍 / 👎.

@benjamin-747 benjamin-747 enabled auto-merge March 13, 2026 08:55
- Add BUCKD_STARTUP_TIMEOUT=30 and BUCKD_STARTUP_INIT_TIMEOUT to all
  buck2 command invocations (Buck2::command, get_repo_targets, build)
  to prevent daemon startup timeouts under slow I/O environments
- Bump scorpiofs dependency from 0.1.1 to 0.2.0
- Increase scorpio load_dir_depth from 3 to 5 and fetch_file_thread
  from 10 to 20 for better prefetch coverage and concurrency

Signed-off-by: Luxian <lux1an@qq.com>
@benjamin-747 benjamin-747 added this pull request to the merge queue Mar 13, 2026
Merged via the queue into web3infra-foundation:main with commit 719e955 Mar 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants