fix(orion): retain Antares mounts and improve dicfuse startup diagnostics#2026
fix(orion): retain Antares mounts and improve dicfuse startup diagnostics#2026benjamin-747 merged 2 commits intoweb3infra-foundation:mainfrom
Conversation
Ivanbeethoven
commented
Mar 18, 2026
Ivanbeethoven
commented
- keep mount points available after build and target-discovery failures for debugging
- add dicfuse root tree logging and optional startup test mount
- relax systemd tmp/mount isolation settings for FUSE runtime compatibility
…tics Signed-off-by: Luxian <lux1an@qq.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1c064f117
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tracing::info!( | ||
| "[Task {}] Build completed — mount directories retained for debugging: \ | ||
| new_repo mountpoint={}; \ | ||
| old_repo mountpoint={}", | ||
| id, |
There was a problem hiding this comment.
In build(), the post-build path now only logs that mount directories are retained and never calls unmount_antares_fs for either the new or old repo mount. In a long-lived runner this leaks at least two Antares/FUSE mounts per successful build (and additional mounts from failed target-discovery attempts), which will eventually exhaust mount/disk resources and cause later builds to fail. The previous behavior cleaned up by default and only retained mounts behind an explicit flag.
Useful? React with 👍 / 👎.
| Err(_) => true, | ||
| } |
There was a problem hiding this comment.
is_test_mount_enabled() returns true when ORION_ENABLE_ANTARES_TEST_MOUNT is unset, so every default startup creates the synthetic antares_test mount. That makes the diagnostic probe mandatory and adds persistent mount state even when operators did not request it, increasing resource usage and conflicting with the “optional test mount” intent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR adjusts Orion’s Antares/Dicfuse integration and runtime environment to make FUSE mounts easier to debug by retaining mounts and adding startup diagnostics, alongside systemd sandboxing relaxations for compatibility.
Changes:
- Retain Antares mount directories across build flow (including target-discovery failures) and log retained mountpoints.
- Add Dicfuse startup diagnostics: workspace root tree logging and an optional “test mount” during warmup.
- Relax systemd isolation settings (
PrivateTmp,PrivateMounts) to better support FUSE runtime behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| orion/systemd/orion-runner.service | Disables PrivateTmp and PrivateMounts isolation to reduce FUSE mount incompatibilities. |
| orion/src/buck_controller.rs | Removes unmount RAII guard and keeps Antares mounts around, updating logs accordingly. |
| orion/src/antares.rs | Adds dicfuse root tree logging and a configurable startup test mount after dicfuse warmup. |
Comments suppressed due to low confidence (1)
orion/src/buck_controller.rs:608
- On target-discovery failure, the code logs and proceeds to the next attempt without unmounting the two mounts created for this attempt. This can leak up to 2 mounts per attempt and will compound under repeated failures. If mounts are meant to be retained only for debugging, consider unmounting between attempts unless retention is explicitly enabled, and include the mount IDs/paths in a structured way for postmortems.
tracing::warn!(
"[Task {}] Failed to get build targets (attempt {}/{}): {}. Mounts retained for debugging (old={}, new={}).",
id,
attempt,
MAX_TARGETS_ATTEMPTS,
e,
old_repo_mount_point,
repo_mount_point,
);
last_targets_error = Some(e);
if attempt == MAX_TARGETS_ATTEMPTS {
break;
}
}
| let id_for_old_repo = format!("{id}-old-{attempt}"); | ||
| let (old_repo_mount_point, mount_id_old_repo) = | ||
| let (old_repo_mount_point, _mount_id_old_repo) = | ||
| mount_antares_fs(&id_for_old_repo, None).await?; | ||
| let guard_old_repo = MountGuard::new(mount_id_old_repo.clone(), id_for_old_repo); | ||
|
|
||
| let id_for_repo = format!("{id}-{attempt}"); | ||
| let (repo_mount_point, mount_id) = mount_antares_fs(&id_for_repo, cl_arg).await?; | ||
| let guard = MountGuard::new(mount_id.clone(), id_for_repo); | ||
| let (repo_mount_point, _mount_id) = mount_antares_fs(&id_for_repo, cl_arg).await?; |
| tracing::info!( | ||
| "[Task {}] Build completed — mount directories retained for debugging: \ | ||
| new_repo mountpoint={}; \ | ||
| old_repo mountpoint={}", | ||
| id, | ||
| mount_point, | ||
| old_repo_mount_point_saved.as_deref().unwrap_or("<unknown>"), | ||
| ); |
| let v = v.trim().to_ascii_lowercase(); | ||
| !(v == "0" || v == "false" || v == "no" || v == "off") | ||
| } | ||
| Err(_) => true, |
| fn log_dicfuse_root_tree() { | ||
| let root = PathBuf::from(scorpiofs::util::config::workspace()); | ||
| let max_depth = std::env::var("ORION_DICFUSE_ROOT_TREE_DEPTH") | ||
| .ok() | ||
| .and_then(|v| v.parse::<usize>().ok()) | ||
| .unwrap_or(2); | ||
| let max_entries = std::env::var("ORION_DICFUSE_ROOT_TREE_MAX_ENTRIES") | ||
| .ok() | ||
| .and_then(|v| v.parse::<usize>().ok()) | ||
| .unwrap_or(200); | ||
|
|
||
| tracing::info!( | ||
| root = %root.display(), | ||
| max_depth, | ||
| max_entries, | ||
| "Dicfuse init: printing workspace root tree" | ||
| ); | ||
|
|
||
| if !root.exists() { | ||
| tracing::warn!("Dicfuse workspace path does not exist: {}", root.display()); | ||
| return; | ||
| } | ||
|
|
||
| let mut printed = 0usize; | ||
| tracing::info!("[dicfuse-root] /"); | ||
| log_tree_recursive(&root, &root, 0, max_depth, max_entries, &mut printed); | ||
|
|
f6d8cf5
