Skip to content

Transformation.hs refactoring #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Transformation.hs refactoring #41

wants to merge 17 commits into from
+462 −494

Conversation

webdevred
Copy link
Owner

@webdevred webdevred commented Sep 2, 2025 •
edited
Loading

  • Updates sorting, renaming, and vertex forest construction to operate on directly CommentGroups.
  • Handles comments and global metas more consistently across vertex trees.
  • Reuses MetaMaps across CommentGroups to optimize memory usage.
  • Splits large module into VertexExtraction and Transformation for clearer structure.
  • Preserves existing vertex coordinates and behavior; no functional changes.
  • Add support for multiple groups of same types with different prefixes

Branch called new_transformation2 to celebrate the joy when new_transformation was merged into master after the summer.

@webdevred webdevred force-pushed the new_transformation2 branch 10 times, most recently from 7a8f709 to f6c32b9 Compare September 3, 2025 14:59
@webdevred
Refactored vertex extraction to separate module
65e2bf2
@webdevred
Replace T.dropWhileEnd isDigit with dropIndex
4e64ab3
@webdevred
Refactor VertexTree to remove VertexTreeEntry
90508c2 
- Removed the VertexTreeEntry type entirely.
- Updated VertexTree to store comments and comment groups directly (tComments, tCommentGroups).
- Refactored transformation functions to work with CommentGroup directly instead of VertexTreeEntry.
- Improved handling of comments and their association with vertices.
- Removed legacy tMetaNodes and simplified meta handling in VertexTree.
- Structural refactor that also improves comment processing.
@webdevred
Dont account for SupportTree when calculating globals and locals
dc56bdc
@webdevred
Properly add sideComment to groups if missing there are no tComments
cf7ba27
@webdevred
Replaced foldM/Either-based accumulation with strict foldl
5090131
@webdevred
moveVerticesInVertexForest no longer returns Either, it cant fail
b7dc407
@webdevred
Added support for vertex trees with different vertex prefixes
12186b9
@webdevred
Added automatic comment for comment mentioned in previous commit
26b9c51
@webdevred
Renamed CommentGroup to AnnotatedVertex
467ce64
@webdevred
Updated VertexTree to store NonEmpty (NonEmpty AnnotatedVertex)
67c52a5
@webdevred
Improve globals calculation
7b77b29
@webdevred
getVertexForestGlobals refinements
b5c0730
@webdevred
Refactor AnnotatedVertex field names from c* to a*
cb25c05 
- Renamed fields in `AnnotatedVertex`:
  * cComments -> aComments
  * cVertex   -> aVertex
  * cMeta     -> aMeta
- Updated all references in:
  * `Transformation.hs`
  * `VertexExtraction.hs`
@webdevred
Migrate to reludes NonEmpty
f2ed9c6
@webdevred
Removed redundant foldable1-classes-compat dependency
24bc3f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@webdevred