Skip to content

Conversation

MikeMcC399
Copy link
Contributor

Situation

Although running npm ci executes without error, which usually means that the package-lock.json is fully up-to-date, if npm install is executed, it removes the dev key from the active [email protected] entry in package-lock.json:

$ git diff
diff --git a/package-lock.json b/package-lock.json
index 3729db4..17c9e5b 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -8,7 +8,6 @@
     "": {
       "name": "geckodriver",
       "version": "6.0.1",
-      "dev": true,
       "hasInstallScript": true,
       "license": "MIT",
       "dependencies": {

The fact that npm put the dev key into this entry in PR #660 is probably due to a bug in npm, as it shouldn't be necessary to run npm install twice in order to reach a stable end-state. Combining an earlier version of geckodriver in devDependencies seems to have confused npm. It's an unusual situation. Unfortunately I also didn't anticipate or notice this error at the time.

Change

Run npm install and commit the change.

Verification

git clone https://github.com/webdriverio-community/node-geckodriver
cd node-geckodriver
git clean -xfd # if repeating
npm ci

Confirm no error from npm ci

npm install
git diff

Confirm no change caused by npm install

@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 25, 2025 08:55
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Aug 25, 2025

Currently this repo depends on:

└─┬ [email protected] (current `latest`)
  └─┬ @wdio/[email protected] (current `latest`)
    └── [email protected]

so the above packages would need to be upgraded to geckodriver@^6.0.0 to get the versions aligned.

Edit: I've added webdriverio/webdriverio#14722 to track

@MikeMcC399
Copy link
Contributor Author

@christian-bromann

Are you available to review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant