feat: support for sendBeacon requests #651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardisg
commented
Sep 7, 2023
tehhowch
reviewed
Sep 14, 2023
lib/interceptor.js
Outdated
Comment on lines
95
to
99
| if (data instanceof Blob) { | ||
| return data.text().then(function (payload) { | ||
| return interceptSendBeacon(url, payload); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Should we handle the other non-string kinds? (MDN suggests ArrayBuffer, TypedArray, DataView, FormData, pojos, URLSearchParams)
If we don't explicitly handle them, it would be good to at least verify what users will see in their spec files for those types.
There was a problem hiding this comment.
will try to find some time in the near future to add the other types too
make sure that `if (!sent)` properly triggers for Blob payloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of support for intercepting sendBeacon request queueing in response to issue #640
Additionally, some code formatting fixes were auto applied from prettier that is used as pre-push hook