Skip to content

Add config param to enable rerun multiple times#68

Open
jansmitmans wants to merge 1 commit intowebdriverio-community:mainfrom
jansmitmans:add-multiple-rerun-feature
Open

Add config param to enable rerun multiple times#68
jansmitmans wants to merge 1 commit intowebdriverio-community:mainfrom
jansmitmans:add-multiple-rerun-feature

Conversation

@jansmitmans
Copy link
Copy Markdown
Contributor

@jansmitmans jansmitmans commented Aug 12, 2023

Fixes #25
This PR enables the wdio-rerun-service to feature running failed tests multiple times, ideally reducing the number of failed tests after each try.

@mikesalvia
Copy link
Copy Markdown
Collaborator

@corny1989 Thanks for your other PR! #69

This PR needs to be rebased it looks like.

BUT, as far as this one. I want to get some opinions on this from @esaari and @christian-bromann.

I see the use case for this but is the best place to perform these operations in the service itself?

This functionality would be the same as deleting the rerun data folder before we started our execution? How do you handle overwriting a shell script you are actually running?

This PR is essentially a clearRerunData option correct?

@mikesalvia
Copy link
Copy Markdown
Collaborator

@corny1989 Just saw your comment on the open issue for #25.

So there are 2 parts here:

  • the adding DISABLE_RERUN or not
  • handling directories

I am under the belief we should not be destructive in the service and handle directories outside of the service as my post above indicates, however, would be interested in feedback if this is being done in other WebdriverIO services.

However, yes, we need an option called something like enableRerunDuringRerun (default: false) which if true will not add DISABLE_RERUN to the rerun.sh.

@jansmitmans
Copy link
Copy Markdown
Contributor Author

Hi @mikesalvia,

Thank you for your feedback. I see your point, I am willing to provide a solution that works for you after you have touched based with the other contributors.

Just give me a rough idea how you would like to have this feature and I will contribute it asap.

Cheers,
Jan

@mikesalvia
Copy link
Copy Markdown
Collaborator

@christian-bromann @esaari What are you thinking on this one?

@esaari
Copy link
Copy Markdown
Collaborator

esaari commented Dec 22, 2025

@mikesalvia cc @jansmitmans sorry for very late weigh-in...I'm fine with this option so long as we have the unit test coverage to go along with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate a new rerun.sh file after running the original

3 participants