Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…ort in launcher and pathResolver
…d update imports in launcher and pathResolver
- Added `find-up` dependency version 6.3.0 to `pnpm-lock.yaml` and `package.json`. - Updated `@electron/asar` dependency to version 3.4.1 in `pnpm-lock.yaml`. - Refactored imports in `launcher.ts`, `pathResolver.ts`, and other files to use the new `NormalizedReadResult` type from `package.ts` instead of `read-package-up`.
- Modified import statements in `wdio.electron.conf.ts`, `wdio.tauri-embedded.conf.ts`, and `wdio.tauri.conf.ts` to source `NormalizedPackageJson` from `@wdio/native-types`, ensuring uniformity across configuration files.
- Added mock implementations for `readFile` and updated `readPackageUp` in `@wdio/native-utils` to improve test coverage and reliability. - Adjusted import statements in `api.spec.ts` to use `NormalizedPackageJson` from `@wdio/native-types`, ensuring consistency across test files.
goosewobbler
force-pushed
the
fix/read-package-up
branch
from
4f64bd0 to
94ed252
Compare
- Removed `read-package-up` dependency from multiple package.json files and replaced it with a custom `readPackageUp` function in `@wdio/native-utils`. - Updated imports across various files to utilize the new implementation and ensure consistency with `NormalizedPackageJson`. - Added `find-up` dependency version 6.3.0 to facilitate the new package resolution logic.
goosewobbler
changed the title
read-package-upread-package-up
- Updated the `createBinaryPathResult` function to utilize a new `BinaryPathResultOptions` interface, enhancing type safety and clarity. - Replaced deprecated `success` pattern with the `ok` pattern and adjusted the handling of binary paths and validation attempts. - Ensured consistent usage of optional chaining and default values for better reliability in path generation and validation.
…figurations - Removed `@wdio/native-types` dependency from `package.json` and `pnpm-lock.yaml`. - Updated `turbo.json` to eliminate the dependency on `@wdio/native-types#build` in the build process, streamlining the build configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69