Skip to content

Conversation

@vishnuv688
Copy link
Member

No description provided.

@vishnuv688
Copy link
Member Author

vishnuv688 commented Aug 1, 2025

image

@christian-bromann

  1. I’ve successfully filtered the Action commands to only include those relevant to the test cases. However, in the event of a test failure, some commands (like getText() in this case) are re-triggered multiple times due to retries. I also want to ignore internal selector commands like $ and $$. Do you have any suggestions on how to prevent these retries from being logged or how to filter them out effectively?

  2. [RESOLVED - IGNORE] Once the test execution completes, the DevTools window is closed immediately after the session is deleted (in the after hook). For now, I’ve added a browser.pause() for 5 minutes to keep it open temporarily. I also tried adding a WebSocket listener that waits for the user to click a "close" button before allowing the session to end, but that approach didn’t work as expected. Could you suggest a better way to delay session teardown until manual interaction is completed?

@christian-bromann
Copy link
Member

  1. I also want to ignore internal selector commands like $ and $$. Do you have any suggestions on how to prevent these retries from being logged or how to filter them out effectively?

I would suggest to elevate these command retries. We may not have enough information about which command is retried or if a command is called as part of a retry. I am open to change that. Maybe for now we can just ignore all retries all together? Open for suggestions / don't have a strong opinion here.

@vishnuv688
Copy link
Member Author

  1. I also want to ignore internal selector commands like $ and $$. Do you have any suggestions on how to prevent these retries from being logged or how to filter them out effectively?

I would suggest to elevate these command retries. We may not have enough information about which command is retried or if a command is called as part of a retry. I am open to change that. Maybe for now we can just ignore all retries all together? Open for suggestions / don't have a strong opinion here.

@christian-bromann Retries are now consolidated into a single entry, and selector commands are ignored since they are not top-level user actions.

I am currently refining the generated trace file to eliminate duplicate test case entries and am open to suggestions.
image

@christian-bromann
Copy link
Member

@vishnuv688 awesome 👏

@vishnuv688
Copy link
Member Author

@christian-bromann, when do you think we can merge this PR? As the package is not yet fully complete and won’t be published until it is, it might be better to merge in smaller chunks. This would make both code reviews and development more manageable. What are your thoughts?

@vishnuv688 vishnuv688 marked this pull request as ready for review September 1, 2025 09:11
@vishnuv688
Copy link
Member Author

vishnuv688 commented Sep 8, 2025

Metadata tab UI changes
Before:
image

After:
image

@christian-bromann
Copy link
Member

It seems like a lot of CSS is broken in your dev version 🤔 have you been able to fix this?

@vishnuv688
Copy link
Member Author

vishnuv688 commented Sep 8, 2025

It seems like a lot of CSS is broken in your dev version 🤔 have you been able to fix this?

@christian-bromann Can you be specific on which one you are mentioning here?

And one existing issue is with the horizontal dragger, where the section with Source, Log, Console and Network tab is not getting resized when I try to move the horizontal dragger. And this section is not scrollable as well.

Apart from this, is there anything you see seems to be broken? Since I don’t have any reference of the initial devtools that you were working on previously.

@christian-bromann
Copy link
Member

Here is a screenshot of the app how it "suppose" to look like:

devtools

I have the feeling TailwindCSS might not be configured correctly anymore.

@vishnuv688
Copy link
Member Author

Here is a screenshot of the app how it "suppose" to look like:

devtools I have the feeling TailwindCSS might not be configured correctly anymore.

Do you have any suggestion on how to resolve the UI related issue? Seems the UI you worked was good.

@vishnuv688
Copy link
Member Author

Option 1:
image

Option 2:
image

@christian-bromann I have downgraded the tailwind to v3 and the UI looks good. I have made some UI changes with the actions that are shown in the UI, so can you let me know which one we can go with? Option 1 or 2?

Or please do let me know if there is any improvement that needs be done here.

@christian-bromann
Copy link
Member

I think options 1 looks great.

Or please do let me know if there is any improvement that needs be done here.

Let's make sure we update the dependencies and work through the breaking changes to ensure we always run on the latest dependencies.

@vishnuv688
Copy link
Member Author

Initial development UI:
image
image
image

@vishnuv688 vishnuv688 merged commit 9b6323f into main Sep 15, 2025
3 of 4 checks passed
vishnuv688 added a commit that referenced this pull request Sep 15, 2025
vishnuv688 added a commit that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants