-
-
Notifications
You must be signed in to change notification settings - Fork 1
DevTool dependencies update #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… not when the test runner completes its execution
I would suggest to elevate these command retries. We may not have enough information about which command is retried or if a command is called as part of a retry. I am open to change that. Maybe for now we can just ignore all retries all together? Open for suggestions / don't have a strong opinion here. |
@christian-bromann Retries are now consolidated into a single entry, and selector commands are ignored since they are not top-level user actions. I am currently refining the generated trace file to eliminate duplicate test case entries and am open to suggestions. |
|
@vishnuv688 awesome 👏 |
|
@christian-bromann, when do you think we can merge this PR? As the package is not yet fully complete and won’t be published until it is, it might be better to merge in smaller chunks. This would make both code reviews and development more manageable. What are your thoughts? |
|
It seems like a lot of CSS is broken in your dev version 🤔 have you been able to fix this? |
@christian-bromann Can you be specific on which one you are mentioning here? And one existing issue is with the horizontal dragger, where the section with Source, Log, Console and Network tab is not getting resized when I try to move the horizontal dragger. And this section is not scrollable as well. Apart from this, is there anything you see seems to be broken? Since I don’t have any reference of the initial devtools that you were working on previously. |
|
@christian-bromann I have downgraded the tailwind to v3 and the UI looks good. I have made some UI changes with the actions that are shown in the UI, so can you let me know which one we can go with? Option 1 or 2? Or please do let me know if there is any improvement that needs be done here. |
|
I think options 1 looks great.
Let's make sure we update the dependencies and work through the breaking changes to ensure we always run on the latest dependencies. |
This reverts commit 9b6323f.











No description provided.