Conversation
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
Overall looks good, some minor comments
| this.#currentFilePath = test.file | ||
| this.#currentTestName = `${test.parent} > ${test.title}` | ||
| await this.#snapshotClient.startCurrentRun(test.file, test.fullTitle, this.#options) | ||
| await this.#snapshotClient.setup(test.file, this.#options) |
There was a problem hiding this comment.
What's the intention of this change?
There was a problem hiding this comment.
The client has been updated so I got errors, to be compliant I had to change this. The reason is shared in the description of the PR where you can see the changes that ViTest made @christian-bromann
There was a problem hiding this comment.
Can we update the version in package.json then?
There was a problem hiding this comment.
It already grabs the latest version with the current package.json but I can do so yes
| const filteredMatchers = {} | ||
| const extend = expectLib.extend | ||
|
|
||
| Object.keys(wdioMatchers).forEach(matcher => { |
There was a problem hiding this comment.
Can we add a comment here about what we are filtering for?
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
Overall looks good, some minor comments
2 participants
Had to update the snapshot client as it got updated as can be observed here: https://github.com/vitest-dev/vitest/pull/6817/files#diff-8f92884bf22a3f371aed2bcb81112b3b6537a5c5cbf0434118f46484d902680a