Skip to content

fix: use a type alias for Service instance#1850

Closed
istankovic wants to merge 1 commit intowebdriverio:mainfrom
wireapp:main
Closed

fix: use a type alias for Service instance#1850
istankovic wants to merge 1 commit intowebdriverio:mainfrom
wireapp:main

Conversation

@istankovic
Copy link

dts-bundle-generator isn't able to handle imports immediately following the implements keyword:

Error: Cannot find symbol for node "Services" in "import('@wdio/types').Services"

So just use a type alias.

dts-bundle-generator isn't able to handle imports immediately following
the `implements` keyword:

    Error: Cannot find symbol for node "Services" in "import('@wdio/types').Services"

So just use a type alias.
@linux-foundation-easycla
Copy link

CLA Not Signed

@christian-bromann
Copy link
Member

@istankovic mind signing the CLA?

@istankovic
Copy link
Author

@istankovic mind signing the CLA?

I'd love to, but unfortunately, it's not so straightforward. This is a "corporate" contribution and given past experience, this may take a long time to go through the process of having the green light from the legal team. (When I say long, I mean on the order of months. I wish I was joking. I started the process, and I'm hopeful this time it won't take long, but I cannot guarantee it.)

Alternatively, the change is trivial and I don't particularly care if someone else does it independently, I would just like this to be fixed so we're able to use this package.

@christian-bromann
Copy link
Member

Alternatively, the change is trivial and I don't particularly care if someone else does it independently, I would just like this to be fixed so we're able to use this package.

I just did that. I think it makes sense to have your org continue the process to sign the CLA so that potential next contributions can be merged directly.

Thank you!

@istankovic
Copy link
Author

Alternatively, the change is trivial and I don't particularly care if someone else does it independently, I would just like this to be fixed so we're able to use this package.

I just did that.

Thank you so much! Also for doing a release. 💜

I think it makes sense to have your org continue the process to sign the CLA so that potential next contributions can be merged directly.

Sure, the process has been started. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants