Skip to content

fix(expect): guard property definitions to avoid “Cannot redefine property” error #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(expect): guard property definitions to avoid “Cannot redefine property” error #1881

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28cc190
fix(expect): guard property definitions to avoid “Cannot redefine pro…
JustasMonkev Jul 6, 2025
d9afb28
fix(expect): guard property definitions to avoid “Cannot redefine pro…
JustasMonkev Jul 6, 2025
fb52975
fix(expect): extend expect with soft assertion helpers
JustasMonkev Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,33 @@ type MatchersObject = Parameters<typeof expectLib.extend>[0]
expectLib.extend(filteredMatchers as MatchersObject)

// Extend the expect object with soft assertions
const expectWithSoft = expectLib as unknown as ExpectWebdriverIO.Expect
Object.defineProperty(expectWithSoft, 'soft', {
value: <T = unknown>(actual: T) => createSoftExpect(actual)
})
const expectWithSoft = expectLib as unknown as ExpectWebdriverIO.Expect & SoftHelpers

// Add soft assertions utility methods
Object.defineProperty(expectWithSoft, 'getSoftFailures', {
value: (testId?: string) => SoftAssertService.getInstance().getFailures(testId)
})
type SoftHelpers = {
soft: <T = unknown>(actual: T) => ReturnType<typeof createSoftExpect>
getSoftFailures: (testId?: string) => ReturnType<SoftAssertService['getFailures']>
assertSoftFailures: (testId?: string) => void
clearSoftFailures: (testId?: string) => void
}

Object.defineProperty(expectWithSoft, 'assertSoftFailures', {
value: (testId?: string) => SoftAssertService.getInstance().assertNoFailures(testId)
})
const helperFactories: SoftHelpers = {
soft: <T = unknown>(actual: T) => createSoftExpect(actual),

Object.defineProperty(expectWithSoft, 'clearSoftFailures', {
value: (testId?: string) => SoftAssertService.getInstance().clearFailures(testId)
})
getSoftFailures: (testId?: string) =>
SoftAssertService.getInstance().getFailures(testId),

assertSoftFailures: (testId?: string) =>
SoftAssertService.getInstance().assertNoFailures(testId),

clearSoftFailures: (testId?: string) =>
SoftAssertService.getInstance().clearFailures(testId)
}

for (const [name, fn] of Object.entries(helperFactories)) {
if (!(name in expectWithSoft)) {
Object.defineProperty(expectWithSoft, name, { value: fn })
}
}

export const expect = expectWithSoft

Expand Down