Skip to content

Conversation

@P-Courteille
Copy link
Contributor

📝 Description

This PR is a fix for issue 657.


🐛 Bug

In the previous version of the code, the functions was added first to each instance of the browser and then to the browser object.

The problem is, @wdio\utils\build\index.js (line 388) already add the command to each instance so the commande added to each instance was overwritten by the one containing the loop of each instance.

→ Resulting in the issue 983

This issue was also the reason of the loop from issue 657, because each instance called the multi remote version of the command when we use:
browserInstance[commandName].apply(browserInstance, args)


🛠️ Solution

Change the addCommand order for Multi Remote

  • first, add the command to Browser in a Multi Remote version (with a loop to do the function in each instance)
  • then, add the command to each instance in a Single Remote version
    For ocr-service

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2025

🦋 Changeset detected

Latest commit: 2f81655

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wdio/ocr-service Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, time and patience

@wswebcreation wswebcreation merged commit 75d31d1 into webdriverio:main Jul 23, 2025
11 checks passed
@wdio-bot
Copy link
Contributor

Hey P-Courteille 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants