Skip to content

Issue 983 for main #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wswebcreation merged 3 commits into from
Jul 23, 2025
Merged

Issue 983 for main #997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d37337e
issue_983_pc
P-Courteille Jul 22, 2025
2515724
Merge branch 'main' into issue_983_pc
wswebcreation Jul 23, 2025
837604a
Update .changeset/upset-areas-wear.md
wswebcreation Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/upset-areas-wear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wdio/visual-service": patch
---

fix: in multiremote, commands are now executed on the requested instances
18 changes: 9 additions & 9 deletions packages/visual-service/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,15 @@ export default class WdioImageComparisonService extends BaseClass {
const browser = this.#browser as WebdriverIO.MultiRemoteBrowser
const browserNames = Object.keys(capabilities)

/**
* Add all the commands to the global browser object that will execute
* on each browser in the Multi Remote
* Start with the page commands
*/
for (const [commandName, command] of Object.entries(pageCommands)) {
this.#addMultiremoteCommand(browser, browserNames, commandName as keyof CommandMap, command)
}

/**
* Add all the commands to each browser in the Multi Remote
*/
Expand All @@ -154,15 +163,6 @@ export default class WdioImageComparisonService extends BaseClass {
await this.#addCommandsToBrowser(browserInstance)
}

/**
* Add all the commands to the global browser object that will execute
* on each browser in the Multi Remote
* Start with the page commands
*/
for (const [commandName, command] of Object.entries(pageCommands)) {
this.#addMultiremoteCommand(browser, browserNames, commandName as keyof CommandMap, command)
}

/**
* Add all the element commands to the global browser object that will execute
* on each browser in the Multi Remote
Expand Down