Update crud-controller.stub for Backpack v4 #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the
crud-controller.stubto generate Backpack v4 controllers.Motivation and context
The package did not provide a way to generate Backpack v4 controllers.
How has this been tested?
No, it has not! PLEASE DON'T MERGE THIS YET. Before we merge this we need:
Another IMPORTANT problem with this PR is that there's no
backpack/crudrequirement towebfactor/laravel-generators. This means that it assumes the user is running a certain Backpack version that is compatible with the stub. The current PR assumes they're running Backpack v4, since that's the current version, that everybody is installing (Solution 1).(Solution 2) A different way to approach this would be to have two controller stubs:
crud3-controller.stubandcrud4-controller.stub, and before generating the crud controller, to see which Backpack version is installed and use the correct Stub. This is a little more complicated, but not too complicated. It would probably require adding a dependency (ocramius/package-versions) to check the currently installed version.I don't know if it's really necessary though - why support Backpack 3.x when 4.x is here. What's you position on this? Solution 1 or Solution 2?
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!