Respect SemVer semantics when comparing package versions (Case 162267)

Comparing a normalised string is not enough.

Fixes #49

Author: janopae

src/AppBundle/Entity/VersionConstraint.php

@@ -2,6 +2,7 @@
 
 namespace AppBundle\Entity;
 
+use Composer\Semver\Comparator;
 use Composer\Semver\VersionParser;
 use InvalidArgumentException;
 
@@ -40,37 +41,10 @@ public function __construct($operator, $versionString)
      */
     public function matches(PackageVersion $packageVersion)
     {
-        switch ($this->operator) {
-            case 'all':
-                return true;
-                break;
-            case '<':
-                if ($packageVersion->getNormalizedVersion() < $this->normalizedVersionString) {
-                    return true;
-                }
-                break;
-            case '<=':
-                if ($packageVersion->getNormalizedVersion() <= $this->normalizedVersionString) {
-                    return true;
-                }
-                break;
-            case '>':
-                if ($packageVersion->getNormalizedVersion() > $this->normalizedVersionString) {
-                    return true;
-                }
-                break;
-            case '>=':
-                if ($packageVersion->getNormalizedVersion() >= $this->normalizedVersionString) {
-                    return true;
-                }
-                break;
-            case '==':
-                if ($packageVersion->getNormalizedVersion() == $this->normalizedVersionString) {
-                    return true;
-                }
-                break;
+        if ('all' === $this->operator) {
+            return true;
         }
 
-        return false;
+        return Comparator::compare($packageVersion->getNormalizedVersion(), $this->operator, $this->normalizedVersionString);
     }
 }

src/AppBundle/Tests/Entity/VersionConstraintTest.php

@@ -13,9 +13,17 @@ class VersionConstraintTest extends TestCase
     public static function provideCases(): Generator
     {
         yield ['<', '2.0.0', ['1.0.0'], ['3.0.0']];
+        yield ['<', '2.2.0', ['2.1.0'], ['2.10.0']];
+        yield ['<', '2.10.0', ['2.2.0'], ['2.11.0']];
         yield ['<=', '2.0.0', ['1.0.0', '2.0.0'], ['3.0.0']];
+        yield ['<=', '2.2.0', ['2.1.0', '2.2.0'], ['2.10.0']];
+        yield ['<=', '2.10.0', ['2.2.0', '2.10.0'], ['2.11.0']];
         yield ['>', '2.0.0', ['3.0.0'], ['1.0.0']];
+        yield ['>', '2.2.0', ['2.10.0'], ['2.1.0']];
+        yield ['>', '2.10.0', ['2.11.0'], ['2.2.0']];
         yield ['>=', '2.0.0', ['2.0.0', '3.0.0'], ['1.0.0']];
+        yield ['>=', '2.2.0', ['2.10.0', '2.2.0'], ['2.1.0']];
+        yield ['>=', '2.10.0', ['2.11.0', '2.10.0'], ['2.2.0']];
         yield ['==', '2.0.0', ['2.0.0'], ['1.0.0', '3.0.0']];
         yield ['all', '2.0.0', ['1.0.0', '2.0.0', '3.0.0'], []];
     }