Get ImportProjectTaskTest closer to real life (Case 205891)#59
Merged
Get ImportProjectTaskTest closer to real life (Case 205891)#59
Conversation
Until now, the test tests almost nothing: It doesn't verify results and acts rather as a smoke test. But it also mocks away all the dependencies, and only tests the few lines of the `import` method against empty mocks rather than real services. This commit shows that it is possible to test way more real-life interaction with even less code. Only PackageVersionFetcher and VcsDriverFactory are mocked now, to prevent real network requests. For more test result verification, we should use a tool like Foundry.
janopae
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the test tests almost nothing:
It doesn't verify results and acts rather as a smoke test. But it also mocks away all the dependencies, and only tests the few lines of the
importmethod against empty mocks rather than real services.This commit shows that it is possible to test way more real-life interaction with even less code. Only PackageVersionFetcher and VcsDriverFactory are mocked now, to prevent real network requests.
For more test result verification, we should use a tool like Foundry.