Skip to content

docs: opened the link stories in storybook in new tabs to improve UX #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/new-admin-ui
Choose a base branch
from
Open

docs: opened the link stories in storybook in new tabs to improve UX #4638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions packages/admin-ui/src/Link/Link.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type Story = StoryObj<typeof Link>;
export const Default: Story = {
args: {
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -36,6 +37,7 @@ export const LinkXl: Story = {
args: {
size: "xl",
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -45,6 +47,7 @@ export const LinkLg: Story = {
args: {
size: "lg",
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -54,6 +57,7 @@ export const LinkMd: Story = {
args: {
size: "md",
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -63,6 +67,7 @@ export const LinkSm: Story = {
args: {
size: "sm",
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -83,6 +88,7 @@ export const InheritedSize: Story = {
},
args: {
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -92,6 +98,7 @@ export const WithUnderline: Story = {
args: {
underline: true,
to: "#",
target: "_blank",
children:
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce tempus tortor eu sapien interdum rhoncus."
}
Expand All @@ -115,7 +122,8 @@ export const PrimaryNegative: Story = {
},
args: {
...Default.args,
variant: "primary-negative"
variant: "primary-negative",
target: "_blank"
}
};

Expand All @@ -137,18 +145,20 @@ export const SecondaryNegative: Story = {
},
args: {
...Default.args,
variant: "secondary-negative"
variant: "secondary-negative",
target: "_blank"
}
};

export const Documentation: Story = {
args: {
to: "#",
to: "https://www.webiny.com",
variant: "primary",
size: "md",
underline: false,
disabled: false,
children: "This is a link"
children: "This is a link",
target: "_blank"
},
argTypes: {
to: {
Expand Down Expand Up @@ -183,6 +193,12 @@ export const Documentation: Story = {
description: "The content of the link. It can be any valid React node.",
control: "text",
defaultValue: "This is a link"
},
target: {
description: "The target attribute for the link",
control: "select",
options: ["_blank", "_self", "_parent", "_top"],
defaultValue: "_blank"
}
}
};