Skip to content

Refactor Headless CMS Field Section and Object Field Wrapper Styling to Align with Design System #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Refactor Headless CMS Field Section and Object Field Wrapper Styling to Align with Design System #4757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc353b3
refactor(headless-cms): update field section styling
ku5ic Oct 30, 2025
be20a83
refactor: simplify object field wrapper styling
ku5ic Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions packages/app-headless-cms/src/admin/plugins/fieldRenderers/DynamicSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,27 +82,25 @@ const DynamicSection = ({
<Bind.ValidationContainer>
<ParentFieldProvider value={value} path={Bind.parentName}>
{showLabel ? (
<div
className={
"relative mb-xl mt-md border-b-sm border-accent-dimmed"
}
>
<>
<Heading
level={6}
level={5}
className={
"webiny_group-label-text absolute bottom-[-10px] pr-sm text-accent-primary bg-white"
"webiny_group-label-text mt-xl mb-sm relative text-accent-primary after:absolute after:z-0 after:inset-x-0 after:top-1/2 after:-translate-y-1/2 after:block after:content-[''] after:h-px after:border-primary-300 after:border-b-1 after:flex-1 after:min-w-0"
}
>
{`${field.label} ${
bindFieldValue.length
? `(${bindFieldValue.length})`
: ""
}`}
<span className="relative z-1 pr-md bg-white">
{`${field.label} ${
bindFieldValue.length
? `(${bindFieldValue.length})`
: ""
}`}
</span>
</Heading>
{field.helpText && (
<FormComponentDescription text={field.helpText} />
)}
</div>
</>
) : null}
<Grid className={classSet(gridClassName, style.gridContainer)}>
<>
Expand Down
32 changes: 12 additions & 20 deletions packages/app-headless-cms/src/admin/plugins/fieldRenderers/object/singleObjectInline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,30 +38,22 @@ const plugin: CmsModelFieldRendererPlugin = {
<Bind.ValidationContainer>
<ParentFieldProvider value={bindProps.value} path={Bind.parentName}>
<ParentValueIndexProvider index={-1}>
<div
<Heading
level={5}
className={
"relative mb-xl mt-md border-b-sm border-accent-default"
"webiny_group-label-text mt-xl mb-sm relative text-accent-primary after:absolute after:z-0 after:inset-x-0 after:top-1/2 after:-translate-y-1/2 after:block after:content-[''] after:h-px after:border-primary-300 after:border-b-1 after:flex-1 after:min-w-0"
}
>
<Heading
level={6}
className={
"webiny_group-label-text absolute bottom-[-10px] pr-sm text-accent-primary bg-white"
}
>
<span className="relative z-1 pr-md bg-white">
{field.label}
</Heading>
{field.helpText && (
<FormComponentDescription>
{field.helpText}
</FormComponentDescription>
)}
</div>
<div
className={
"p-md border-sm border-neutral-dimmed-darker rounded-md"
}
>
</span>
</Heading>
{field.helpText && (
<FormComponentDescription>
{field.helpText}
</FormComponentDescription>
)}
<div className={"py-md-extra"}>
<Fields
gridClassName={fieldsGridStyle}
Bind={Bind}
Expand Down
Loading