Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 3, 2026

Workspace templates are copied to .webiny/workspace/apps/* in user projects. Previously, these templates extended the user's root tsconfig.json, causing user TypeScript configuration changes (e.g., noPropertyAccessFromIndexSignature) to affect internal workspace code compilation.

Changes

  • Removed inheritance from user tsconfig: Deleted extends property from all workspace template tsconfig files
  • Added standalone minimal config: Set skipLibCheck: true and checkJs: false to disable type checking entirely
  • Isolated workspace from user settings: Workspace code no longer adapts to user TypeScript preferences

Files Modified

  • packages/project-aws/_templates/appTemplates/admin/tsconfig.json
  • packages/project-aws/_templates/appTemplates/api/graphql/tsconfig.json
  • packages/project-aws/_templates/appTemplates/api/migration/tsconfig.json
  • packages/project-aws/_templates/appTemplates/api/fileManager/manage/tsconfig.json

Before:

{
  "extends": "../../../../tsconfig.json",
  "include": ["src"],
  "compilerOptions": {
    "composite": false
  }
}

After:

{
  "include": ["src"],
  "compilerOptions": {
    "skipLibCheck": true,
    "noEmit": true,
    "allowJs": true,
    "checkJs": false,
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "node",
    "jsx": "react",
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "composite": false
  }
}
Original prompt

this file is part of a template, which is copied in users' projects into .webiny/workspace/admin/tsconfig.json.. basically we have a react app in there, which is hidden from users, and internally we're doing some code juggling in there.
all good, but....
we don't want typescript to be checking things in here. Sure, we'd want to do it.. but the problem is that users migh change some of theirs ts settings, which could cause issues in the workspace code.
For example, we're using someRecord.xyz, but users might want to adjust their ts config to only allow someRecord["xyz"]. We don't want the workspace code generation to adapt based on user's adjusted ts config, too much hassle.
So, as proposed.. let's just turn off typscript checking in the .webiny/workspace/admin folder.
Come to think of it, we want to turn it off completely for .webiny/workspace b/c it's not just admin that's in there, we also have api and core.

The user has attached the following files from their workspace:

  • packages/project-aws/_templates/appTemplates/admin/tsconfig.json

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Disable TypeScript checking in workspace directory Disable TypeScript checking in workspace templates Jan 3, 2026
Copilot AI requested a review from adrians5j January 3, 2026 14:31
@adrians5j adrians5j changed the base branch from copilot/update-database-setup-logic to next January 6, 2026 14:46
@Pavel910 Pavel910 added this to the 6.0.0 milestone Jan 6, 2026
@adrians5j
Copy link
Member

/cypress

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Cypress E2E tests have been initiated (for more information, click here). ✨

@adrians5j
Copy link
Member

/cypress

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Cypress E2E tests have been initiated (for more information, click here). ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants