add lender-tooltip on a lenderrequest with link to user #5772
+107
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch0rizo
approved these changes
Nov 1, 2025
Comment on lines
29
to
36
| type TimeRangeWithUser = { | ||
| start: string; | ||
| end: string; | ||
| fullDay: boolean; | ||
| userDisplayName: String; | ||
| userName: String; | ||
|
|
||
| }; |
Contributor
There was a problem hiding this comment.
Is there a difference between capitalized string and not?
Member
Author
There was a problem hiding this comment.
The shouldn't be capitalized. Looking at the files changed they are not capitalized, but looking at your comment they are, so I don't know
ShaileshS1702
force-pushed
the
add_user_hover_on_lending_request
branch
from
09f71f5 to
b85fb4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When hovering a lendingobject in the calendar, you now can see who the lender is. Works with both full day and partial day lendings
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Caution
Make sure your images do not contain any real user information.
Testing
no tests have been written
ABA-1589