Clarify division operator rounding#909
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Dec 12, 2025
Merged
Conversation
Collaborator
Author
Err, this line in |
Contributor
|
re bikeshed error, see https://lists.w3.org/Archives/Public/spec-prod/2025OctDec/thread.html#msg4 - bikeshed updates including in the parsing code |
Member
|
Indentation is indeed correct. One possible workaround is to add an empty line before the closing |
Collaborator
Author
|
Thanks @dontcallmedom and @anssiko 👍. |
anssiko
approved these changes
Dec 9, 2025
Collaborator
Author
|
@huningxin : I'm going to merge this as it's really minor editorial, and it cleans up the build failure for Bruce's PR too. If you have any feedback, I'll follow up with a new PR. |
github-actions bot
added a commit
that referenced
this pull request
Dec 12, 2025
SHA: 94bcacb Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor clarification that
divexpects to round toward zero (truncation), rather than say being floored to negative zero like Numpy's floor_divide.Preview | Diff