Enforce non-yoda style (#1074)

Author: spawnia

.php-cs-fixer.php

@@ -11,4 +11,9 @@
     'no_superfluous_phpdoc_tags' => [
         'allow_mixed' => true,
     ],
+    'yoda_style' => [
+        'equal' => false,
+        'identical' => false,
+        'less_and_greater' => false,
+    ],
 ]);

benchmarks/LexerBench.php

@@ -31,6 +31,6 @@ public function benchIntrospectionQuery(): void
 
         do {
             $token = $lexer->advance();
-        } while (Token::EOF !== $token->kind);
+        } while ($token->kind !== Token::EOF);
     }
 }

benchmarks/Utils/QueryGenerator.php

@@ -30,7 +30,7 @@ public function __construct(Schema $schema, float $percentOfLeafFields)
     {
         $this->schema = $schema;
 
-        assert(0 < $percentOfLeafFields && $percentOfLeafFields <= 1);
+        assert($percentOfLeafFields > 0 && $percentOfLeafFields <= 1);
 
         $totalFields = 0;
         foreach ($schema->getTypeMap() as $type) {

benchmarks/Utils/SchemaGenerator.php

@@ -70,7 +70,7 @@ protected function createType(int $nestingLevel, ?string $typeName = null): Obje
         }
 
         ++$this->typeIndex;
-        if (null === $typeName) {
+        if ($typeName === null) {
             $typeName = 'Level_' . $nestingLevel . '_Type' . $this->typeIndex;
         }
 

examples/00-hello-world/graphql.php

@@ -56,7 +56,7 @@
     ]);
 
     $rawInput = file_get_contents('php://input');
-    if (false === $rawInput) {
+    if ($rawInput === false) {
         throw new RuntimeException('Failed to get php://input');
     }
 

examples/01-blog/Blog/Data/DataSource.php

@@ -181,7 +181,7 @@ public static function findLatestStory(): ?Story
      */
     public static function findStories(int $limit, ?int $afterId = null): array
     {
-        $start = null !== $afterId
+        $start = $afterId !== null
             ? (int) array_search($afterId, array_keys(self::$stories), true) + 1
             : 0;
 

examples/01-blog/Blog/Type/CommentType.php

@@ -62,7 +62,7 @@ public function resolveAuthor(Comment $comment): ?User
 
     public function resolveParent(Comment $comment): ?Comment
     {
-        if (null !== $comment->parentId) {
+        if ($comment->parentId !== null) {
             return DataSource::findComment($comment->parentId);
         }
 

examples/01-blog/Blog/Type/Scalar/EmailType.php

@@ -54,6 +54,6 @@ public function parseLiteral(Node $valueNode, ?array $variables = null): string
      */
     private function isEmail($value): bool
     {
-        return false !== filter_var($value, FILTER_VALIDATE_EMAIL);
+        return filter_var($value, FILTER_VALIDATE_EMAIL) !== false;
     }
 }

examples/01-blog/Blog/Type/Scalar/UrlType.php

@@ -55,6 +55,6 @@ public function parseLiteral(Node $valueNode, ?array $variables = null): string
     private function isUrl($value): bool
     {
         return is_string($value)
-            && false !== filter_var($value, FILTER_VALIDATE_URL);
+            && filter_var($value, FILTER_VALIDATE_URL) !== false;
     }
 }

examples/01-blog/graphql.php

@@ -30,7 +30,7 @@
     // Prepare context that will be available in all field resolvers (as 3rd argument):
     $appContext = new AppContext();
     $currentlyLoggedInUser = DataSource::findUser(1);
-    assert(null !== $currentlyLoggedInUser);
+    assert($currentlyLoggedInUser !== null);
     $appContext->viewer = $currentlyLoggedInUser;
     $appContext->rootUrl = 'http://localhost:8080';
     $appContext->request = $_REQUEST;