Call resolveValue before calling resolveType
#1781
Merged
+55
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hindsight it makes more sense to first resolve the value to the desired type before calling `resolveType`. Related to webonyx#1776
|
Haha, I actually also did do that initially, but figured you wouldn't like that big diff so removed it and kept it simpler. But way better, to have the same order as it's called. Thanks! |
|
Released with https://github.com/webonyx/graphql-php/releases/tag/v15.25.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight it makes more sense to first resolve the value to the desired type before calling
resolveType.I figured this out while implementing this new feature in our project.
Related to #1776