Skip to content

fix: nonsensible intersection #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

colinaaa
Copy link
Contributor

@colinaaa colinaaa commented Aug 5, 2025

After upgrading to Webpack ^5.100.0 (lynx-family/lynx-stack#1418), we got errors related with types:

- JsonObjectTypes[key]: string & Array<JsonValueTypes>
  - nonsensible intersection

- JsonObjectTypes[key]: number & Array<JsonValueTypes>
  - nonsensible intersection

- JsonObjectTypes[key]: false & Array<JsonValueTypes>
  - nonsensible intersection

- JsonObjectTypes[key]: true & Array<JsonValueTypes>
  - nonsensible intersection

See: https://github.com/lynx-family/lynx-stack/actions/runs/16744114403/job/47401398078

colinaaa added a commit to lynx-family/lynx-stack that referenced this pull request Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.05%. Comparing base (367d0f6) to head (eca7c94).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   93.06%   93.05%   -0.01%     
==========================================
  Files          44       44              
  Lines        2133     2132       -1     
  Branches      651      650       -1     
==========================================
- Hits         1985     1984       -1     
  Misses        119      119              
  Partials       29       29              
Flag Coverage Δ
integration 93.05% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
Copy link
Member

@colinaaa Looks like lint is failed

@alexander-akait alexander-akait merged commit 86ff212 into webpack:main Aug 5, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants