feat(tsconfig): support JSONC comments in tsconfig.json files#476
feat(tsconfig): support JSONC comments in tsconfig.json files#476alexander-akait merged 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
- Coverage 93.42% 92.67% -0.76%
==========================================
Files 49 50 +1
Lines 2388 2483 +95
Branches 719 751 +32
==========================================
+ Hits 2231 2301 +70
- Misses 128 149 +21
- Partials 29 33 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const config = await readJson(fileSystem, configFilePath); | ||
| const config = await readJson(fileSystem, configFilePath, { | ||
| stripComments: true, | ||
| }); |
There was a problem hiding this comment.
The main problem here what readJson will not cache fs calls, because we have options here, we cache only calls without options, maybe we need to introduce readJsonc
There was a problem hiding this comment.
Here, we cache the fs calls. We’re not passing the arguments through to FileSystem — this is a readJson helper wrapped in utils. I’m not sure whether we still need to implement a readJsonc method in FileSystem.
https://github.com/webpack/enhanced-resolve/pull/476/changes#diff-68a304bd1f2cab3fd1377549ad55b1bd26e250aa52bf9afbba06a6da4280876fR41
|
@xiaoxiaojx let's rebase, wrong order merge 😞 and we can merge |
Summary
Fixes #475
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing