-
-
Notifications
You must be signed in to change notification settings - Fork 505
fix: allow react native bundle files #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
valscion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmyeah makes sense. Can you add a changelog entry as well?
Sure thing! Let me know if that looks good to you |
valscion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks!
|
Thank you so much @valscion! |
|
I would be able to release a new major version once some skipped tests have been debugged why they have stopped working or fix them so that the tests pass afain. If you are able to help me debug why we now need to have I'm right now on vacation from work so am sometimes online. But I can ship a new version regardless once those tests have been fixed. |
|
@ilteoood try v5.0.1, it includes this change |
|
Thanks for the ping @valscion, it works quite well 👌 |
Thanks to Re-Pack, now even React Native projects can use Rspack or Webpack as a bundler instead of Metro.
We would like to use webpack-bundle-analyzer to discover the pain point of our app.
Unfortunately, the React Native assets are stored in a
.bundlesize: this is forcing us to patchwebpack-bundle-analyzerto be able to use it.With this PR, I'm going to address it.