Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Jan 8, 2026

Closes #5587

Action Items:
Change required checks to:

  • CI / Lint & Check Types
  • CI / Test - macos-latest (Node.js 18.x)
  • CI / Test - macos-latest (Node.js 20.x)
  • CI / Test - macos-latest (Node.js 22.x)
  • CI / Test - macos-latest (Node.js 24.x)
  • CI / Test - ubuntu-latest (Node.js 18.x)
  • CI / Test - ubuntu-latest (Node.js 20.x)
  • CI / Test - ubuntu-latest (Node.js 22.x)
  • CI / Test - ubuntu-latest (Node.js 24.x)
  • CI / Test - windows-latest (Node.js 18.x)
  • CI / Test - windows-latest (Node.js 20.x)
  • CI / Test - windows-latest (Node.js 22.x)
  • CI / Test - windows-latest (Node.js 24.x)
  • Validate PR / Lint Commit Messages

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (b550a70) to head (243ee2d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5623   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          13       13           
  Lines        2054     2054           
  Branches      756      756           
=======================================
  Hits         1715     1715           
  Misses        305      305           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas
Copy link
Member

If you need me to do a re-run, let me know on Discord or Slack.

@avivkeller avivkeller marked this pull request as ready for review January 8, 2026 20:30
Copilot AI review requested due to automatic review settings January 8, 2026 20:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modernizes the CI infrastructure by replacing per-commit linting with PR title validation, removing support for Node.js versions older than 18, consolidating workflows, and updating GitHub Actions to pinned versions for better security.

Key Changes

  • Replaces commitlint with PR title validation using amannn/action-semantic-pull-request
  • Removes Node.js 18-specific workarounds (dynamic import polyfills, test mocking)
  • Consolidates the old nodejs.yml workflow into a new streamlined ci.yml
  • Updates GitHub Actions to use pinned commit hashes for security

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/workflows/ci.yml New consolidated CI workflow with lint and test jobs for Node.js 18.x, 20.x, 22.x, 24.x
.github/workflows/validate-pr-title.yml New workflow for validating PR titles against conventional commit format
.github/workflows/nodejs.yml Removed old workflow file (replaced by ci.yml)
.github/workflows/dependency-review.yml Enhanced with better documentation and pinned action versions
.github/dependabot.yml Added GitHub Actions dependency updates
package.json Removed commitlint dependencies and related npm script
package-lock.json Removed all commitlint-related dependencies
commitlint.config.js Removed configuration file
.husky/commit-msg Removed commitlint hook
scripts/prepare-test-for-old-node.js Removed Node.js 18 compatibility script
test/server/open-option.test.js Removed Node.js version-specific mocking logic
CONTRIBUTING.md Updated to clarify PR title requirements
.cspell.json Updated dictionary (removed "commitlint", added "amannn")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller
Copy link
Member Author

@bjohansebas Can you re-run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants