Skip to content

fix: add aria-label prop on nav links #7580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

fix: add aria-label prop on nav links #7580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a755e
fix: add aria-label prop on nav links
snitin315 Mar 14, 2025
a961044
fix: add aria-label prop on nav links
snitin315 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/components/Navigation/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ NavigationItem.propTypes = {
children: PropTypes.node.isRequired,
url: PropTypes.string.isRequired,
isactive: PropTypes.func,
ariaLabel: PropTypes.string,
};

function NavigationItem({ children, url, isactive }) {
function NavigationItem({ children, url, isactive, ariaLabel }) {
let obj = {};
// decide if the link is active or not by providing a function
// otherwise we'll let react-dom makes the decision for us
Expand All @@ -42,6 +43,7 @@ function NavigationItem({ children, url, isactive }) {
target="_blank"
rel="noopener noreferrer"
className={classes}
aria-label={ariaLabel}
>
{children}
</a>
Expand All @@ -54,6 +56,7 @@ function NavigationItem({ children, url, isactive }) {
isActive ? `${classes} !text-blue-200` : classes
}
to={url}
aria-label={ariaLabel}
>
{children}
</NavLink>
Expand All @@ -71,6 +74,7 @@ function NavigationIcon({ children, to, title }) {
to={to}
className="inline-flex items-center text-gray-100 dark:text-gray-200 hover:text-blue-200"
title={`webpack on ${title}`}
aria-label={`webpack on ${title}`}
>
{children}
</Link>
Expand Down Expand Up @@ -118,8 +122,13 @@ function Navigation({ links, pathname, hash = '', toggleSidebar }) {
<Logo />
</Link>
<nav className="hidden md:inline-grid md:grid-flow-col md:gap-x-[18px]">
{links.map(({ content, url, isActive }) => (
<NavigationItem key={url} url={url} isActive={isActive}>
{links.map(({ content, url, isActive, ariaLabel }) => (
<NavigationItem
key={url}
url={url}
isActive={isActive}
ariaLabel={ariaLabel}
>
{content}
</NavigationItem>
))}
Expand Down
9 changes: 7 additions & 2 deletions src/components/Site/Site.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ function Site(props) {
links={[
{
content: 'Documentation',
ariaLabel: 'webpack documentation',
url: '/concepts/',
isactive: (_, location) => {
return /^\/(api|concepts|configuration|guides|loaders|migrate|plugins)/.test(
Expand All @@ -236,8 +237,12 @@ function Site(props) {
)
),
},
{ content: 'Contribute', url: '/contribute/' },
{ content: 'Blog', url: '/blog/' },
{
content: 'Contribute',
url: '/contribute/',
ariaLabel: 'contribute to webpack',
},
{ content: 'Blog', url: '/blog/', ariaLabel: 'webpack blog' },
]}
/>
</div>
Expand Down