feat(starlight): handle Expressive Code's configuration file #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushichan044
changed the title
webpro
approved these changes
Jan 12, 2026
| if (expressiveCodeProp && ts.isPropertyAssignment(expressiveCodeProp)) { | ||
| const initializer = expressiveCodeProp.initializer; | ||
| if (initializer.kind === ts.SyntaxKind.FalseKeyword) { | ||
| isExpressiveCodeEnabled = false; |
Member
There was a problem hiding this comment.
Perhaps we could do an early bail out here?
Contributor
Author
Member
There was a problem hiding this comment.
Yeah, anything we can do to improve performance. If we have our answer, we can stop iterating.
commit: |
Contributor
|
@webpro @sushichan044 Because expressive-code isn't exclusively a starlight feature, it felt funny to me to shoehorn this into the starlight plugin. So I took a try at reworking this branch into it's own knip plugin for expressive-code and opened that as #1493. |
Member
|
Everyone comes in with their own agenda, no solution is perfect here (as Starlight has expressive-code built-in). Your solution is great though! Let's close this one and roll with yours 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1450
Now the starlight plugin checks whether Expressive Code is enabled.
If enabled, adds Expressive Code's config file as an entry.