Add option to write JSONL file with data on URLs not queued#966
Draft
Add option to write JSONL file with data on URLs not queued#966
Conversation
tw4l
changed the title
tw4l
force-pushed
the
issue-965-urls-not-queued-list
branch
from
25a80f2 to
4f78dde
Compare
Member
Author
|
Moving back to draft while I work on adding the new |
tw4l
force-pushed
the
issue-965-urls-not-queued-list
branch
from
220b267 to
9897393
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965
Add
--listNotQueuedargument, which will result in areports/notQueued.jsonlfile with the following elements for each URL encountered that was not queued:urlseedUrldepthreason(one ofoutOfScope,pageLimit, orrobotsTxt)tsThe
reports/directory is new but could be expanded with other crawl-time reporting moving forward. I also considered using a directory likeexcludedPages/, but making a directory for a single file felt silly, and we already use "exclude" to mean a specific thing that is just a subset of why a URL might be encountered but not queued.