Skip to content

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Oct 22, 2025

Resolves #2906

Changes

Overall, a more consistent experience for navigating all workflow crawls and managing crawl-related items.

  • Adds new "Crawl Runs" page under "Crawling" to display all crawl runs, including canceled and failed
  • Enables sorting crawls for by execution time and page count
  • Updates icon for "Canceled" state to not appear as error
  • Update archived item type labels
  • Refactors archived item and crawl deletion confirmation to use same dialog (partially addresses Switch to in-page dialogue boxes #619)
  • Show collections in deletion confirmation
  • Refactors /archived-items/crawl-list.ts component to -> /crawls/crawl-list/ components

Manual testing

Note: New sort fields require building the backend locally.

  1. Log in as crawler
  2. Go to "Crawling". Verify "Workflows" and "Crawl Runs" tabs are shown
  3. Go to "Crawl Runs"
  4. Interact with search, sort, and filters. Verify list controls work as expected.
  5. Choose canceled crawl run. Verify navigation to crawl details view
  6. Choose action menu -> "Delete Crawl". Verify that crawl is deleted without confirmation
  7. Go back to "Crawl Runs"
  8. Choose successful crawl.
  9. Choose action menu -> "Delete Crawl". Verify that confirmation is shown.
  10. Repeat 9 from "Workflow" > "Crawls" and "Archived Items". Verify confirmation dialog is consistent for all crawl/item deletions.

Screenshots

Page Image/video
Crawl Runs Screenshot 2025-10-21 at 5 36 45 PM
Crawl Runs Screenshot 2025-10-21 at 5 38 51 PM
Workflow / Crawls Screenshot 2025-10-21 at 5 38 23 PM
Archived Items Screenshot 2025-10-21 at 6 12 37 PM
Delete Confirmation (when in collections) Screenshot 2025-10-21 at 6 14 50 PM

@SuaYoo SuaYoo changed the title wip: Show all crawl runs feat: Show all crawl runs Oct 22, 2025
@SuaYoo SuaYoo changed the title feat: Show all crawl runs feat: Show all crawl runs + crawl deletion UX improvements Oct 22, 2025
@SuaYoo SuaYoo marked this pull request as ready for review October 22, 2025 01:18
@SuaYoo SuaYoo requested review from emma-sg, ikreymer and tw4l October 22, 2025 01:19
@tw4l
Copy link
Member

tw4l commented Oct 22, 2025

Overall looks great! The one thing I've noticed is that the crawl runs table (and archived items table, as it appears to be the same component) doesn't adjust to smaller screen sizes as well as some of our other tables. Instead of responsively changing shape to fit the screen, some of the columns begin to get cut off. For instance:

Larger screen size

Screenshot 2025-10-22 at 11 25 57 AM

Medium screen size

Screenshot 2025-10-22 at 11 26 07 AM

Small screen size

Screenshot 2025-10-22 at 11 26 18 AM

We could address the responsiveness separately, I leave that up to you. Overall this is a great feature and all tested as expected!

@SuaYoo
Copy link
Member Author

SuaYoo commented Oct 22, 2025

Small screen size

Screenshot 2025-10-22 at 11 26 18 AM

Which browser do you see this in, and are you able to horizontally scroll the table without a scrollbar? Ideally you should be able to see a scrollbar:

Screenshot 2025-10-22 at 9 37 56 AM

(cc @emma-sg )

@tw4l
Copy link
Member

tw4l commented Oct 22, 2025

Which browser do you see this in, and are you able to horizontally scroll the table without a scrollbar? Ideally you should be able to see a scrollbar:

This is in Brave, and there is a horizontal scrollbar to scroll the table, so maybe it's okay after all. I think I was just expecting the row to collapse like the workflows, but now I see many other elements in Browsertrix handle smaller screens like this table.

@SuaYoo
Copy link
Member Author

SuaYoo commented Oct 23, 2025

This is in Brave, and there is a horizontal scrollbar to scroll the table, so maybe it's okay after all. I think I was just expecting the row to collapse like the workflows, but now I see many other elements in Browsertrix handle smaller screens like this table.

It's a good call out, and I'll do a quick pass to address the inconsistent text wrapping at different screen sizes. Will link your comments to the general responsiveness improvements issue: #1348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Show all crawl runs

2 participants