Update collection stats (e.g. date ranges, counts, tags) in background job#3241
Open
Update collection stats (e.g. date ranges, counts, tags) in background job#3241
Conversation
Wherever updating collection counts, tags, and dates would block API respones, this commit moves those operations instead to an asyncio task. It also ensures those tasks aren't garbage collected before they are completed. In addition, this moves updating counts, tags, and dates into a single function update_collection_stats that is used uniformly, as it was previously inconsistent whether the collection's date range was always updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3218
This PR moves updating of collections after changes (e.g. items being added or removed) to a background job, to ensure that collection API requests remain quick.
Changes
asyncio.create_taskhave been updated so that they will not be garbage collected before they complete (see [Task]: Ensure asyncio tasks aren't garbage collected before they complete #3240 for more context and tracking of completing this across the rest of the backend)Testing
Nightly test run: https://github.com/webrecorder/browsertrix/actions/runs/23769472591