Allows multifilewarcwriter to write non compressed WARC files by selective activation.
#916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owadays (and to think this started with Stacker on MS-DOS!), so it makes sense to use **uncompressed** WARC files on a BTRFS or NTFS with it activated. This commit deactivates the WARCIO gzip support when the filename **does not** ends with `.gz`, allowing the user to use these filesystems to reach the compression he wants without having to deal with uncompressing the WARC on use. for webrecorder#915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's the thing: we have file systems with transparent compression nowadays (and to think this started with Stacker on MS-DOS!), so it makes sense to use uncompressed WARC files on a BTRFS or NTFS with it activated. This commit deactivates the WARCIO gzip support when the filename does not ends with
.gz, allowing the user to use these filesystems to reach the compression he wants without having to deal with uncompressing the WARC on use.for #915
This code is being used for 2 months already on a linux box and
btrfsusingzstd:15compression for theWARCfiles. The penalty on writing is negligible,the readings are perceptively faster and the compression level is way better.