fix RTCP RecvDelta i16 bug

yngrtc · yngrtc · commit c0e30bc1e7ac · 2024-06-15T22:41:09.000-07:00
diff --git a/rtcp/src/transport_feedbacks/transport_layer_cc/mod.rs b/rtcp/src/transport_feedbacks/transport_layer_cc/mod.rs
@@ -331,7 +331,7 @@ impl MarshalSize for RecvDelta {
         // big delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta
             && delta >= i16::MIN as i64
-            && delta <= u16::MAX as i64
+            && delta <= i16::MAX as i64
         {
             return 2;
         }
@@ -358,10 +358,10 @@ impl Marshal for RecvDelta {
         // big delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta
             && delta >= i16::MIN as i64
-            && delta <= u16::MAX as i64
+            && delta <= i16::MAX as i64
             && buf.remaining_mut() >= 2
         {
-            buf.put_u16(delta as u16);
+            buf.put_i16(delta as i16);
             return Ok(2);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,7 @@ impl MarshalSize for RecvDelta {`
`331`	`331`	`// big delta`
`332`	`332`	`if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta`
`333`	`333`	`&& delta >= i16::MIN as i64`
`334`		`- && delta <= u16::MAX as i64`
	`334`	`+ && delta <= i16::MAX as i64`
`335`	`335`	`{`
`336`	`336`	`return 2;`
`337`	`337`	`}`
`@@ -358,10 +358,10 @@ impl Marshal for RecvDelta {`
`358`	`358`	`// big delta`
`359`	`359`	`if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta`
`360`	`360`	`&& delta >= i16::MIN as i64`
`361`		`- && delta <= u16::MAX as i64`
	`361`	`+ && delta <= i16::MAX as i64`
`362`	`362`	`&& buf.remaining_mut() >= 2`
`363`	`363`	`{`
`364`		`- buf.put_u16(delta as u16);`
	`364`	`+ buf.put_i16(delta as i16);`
`365`	`365`	`return Ok(2);`
`366`	`366`	`}`
`367`	`367`