Refactor merging of additional TSN blocks#13
Merged
boivie merged 1 commit intowebrtc:mainfrom Aug 21, 2025
Merged
Conversation
The logic for adding new TSNs to the list of received blocks was complex and difficult to follow. It involved a binary search followed by multiple conditional checks to determine how to merge the new TSN with existing blocks. This commit refactors the `add_additional_tsn` method to be more readable and efficient. It now finds the correct insertion point for the new TSN and then uses a simple match statement to handle merging with the previous block, the next, both, or neither.
lndmrk
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for adding new TSNs to the list of received blocks was complex and difficult to follow. It involved a binary search followed by multiple conditional checks to determine how to merge the new TSN with existing blocks.
This commit refactors the
add_additional_tsnmethod to be more readable and efficient. It now finds the correct insertion point for the new TSN and then uses a simple match statement to handle merging with the previous block, the next, both, or neither.