Add Opus for video/mp4 mimetypes#1699
Merged
fippo merged 1 commit intowebrtc:gh-pagesfrom Jan 28, 2025
Merged
Conversation
Currently for Chromium, `mp4a.40.2` is only supported by the hardware audio encoder on Windows, macOS, and Android. We should add `Opus` as another option since `Opus` is a builtin audio codec on all operating systems. This ensures that Linux and ChromeOS can record `video/mp4` without issues.
fippo
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently for Chromium,
mp4a.40.2is only supported by the hardware audio encoder on Windows, macOS, and Android.We should add
Opusas another option sinceOpusis a builtin audio codec on all operating systems.This ensures that Linux and ChromeOS can record
video/mp4without issues.