Skip to content

Drop usage of fs-extra and switch to native fs #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Drop usage of fs-extra and switch to native fs #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/plugins/save-resource-to-fs-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import path from 'path';
import fs from 'fs-extra';
import fs from 'fs';
import { outputFile } from '../utils/fs.js';

class SaveResourceToFileSystemPlugin {
apply (registerAction) {
Expand All @@ -20,13 +21,13 @@ class SaveResourceToFileSystemPlugin {
registerAction('saveResource', async ({resource}) => {
const filename = path.join(absoluteDirectoryPath, resource.getFilename());
const text = resource.getText();
await fs.outputFile(filename, text, { encoding: resource.getEncoding() });
await outputFile(filename, text, resource.getEncoding());
loadedResources.push(resource);
});

registerAction('error', async () => {
if (loadedResources.length > 0) {
await fs.remove(absoluteDirectoryPath);
fs.rmSync(absoluteDirectoryPath, {force: true, recursive: true});
}
});
}
Expand Down
13 changes: 13 additions & 0 deletions lib/utils/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import path from 'path';
import fs from 'fs/promises';

async function outputFile (file, data, encoding) {
const dir = path.dirname(file);
await fs.mkdir(dir, { recursive: true});

return fs.writeFile(file, data, { encoding: encoding });
}

export {
outputFile
};
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"cheerio": "^1.1.2",
"css-url-parser": "^1.0.0",
"debug": "^4.3.1",
"fs-extra": "^11.1.0",
"got": "^14.4.7",
"normalize-url": "^8.0.0",
"p-queue": "^9.0.0",
Expand All @@ -50,6 +49,7 @@
"devDependencies": {
"c8": "^10.0.0",
"eslint": "^8.5.0",
"fs-extra": "^11.1.0",
"mocha": "^11.0.1",
"nock": "^14.0.0",
"should": "^13.2.3",
Expand Down