Open
Conversation
aivus
reviewed
Aug 12, 2024
| // https://github.com/website-scraper/node-website-scraper?tab=readme-ov-file#afterresponse: (binary) This is advised against because of the binary assumption being made can foul up saving of utf8 responses to the filesystem. | ||
| return { | ||
| body: content, | ||
| encoding: 'utf8' |
Member
There was a problem hiding this comment.
@s0ph1e Should we do the same we did in website-scraper?
Member
There was a problem hiding this comment.
Hi @azlarsin,
thank you for your contribution 👍 and sorry for the very late response from my side.
Hi @aivus,
thank you for pinging me. I think, it's a good idea to use the same approach, that already exists in the main module. It would also be nice to have some tests for it (we can use an example in the PR comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: https://github.com/website-scraper/node-website-scraper?tab=readme-ov-file#afterresponse.
Test page:
http://www.csxykj.com/mobile/index.htmlBefore:
<h3>磁致伸缩位移� 感器</h3>,<h5>影响大跨度桥梁施工控制的� � </h5>.After:
<h3>磁致伸缩位移传感器</h3>,<h5>影响大跨度桥梁施工控制的因素</h5>.