Skip to content

fix: puppeteerRunner remove networkidle options from setContent - #1380

Merged
khufu-dev merged 1 commit into
mainfrom
ss/fix-puppeteer
Sep 4, 2026
Merged

fix: puppeteerRunner remove networkidle options from setContent#1380
khufu-dev merged 1 commit into
mainfrom
ss/fix-puppeteer

Conversation

@khufu-dev

Copy link
Copy Markdown
Contributor

Puppeteer removed the networkidle options from setContent which never actually worked puppeteer/puppeteer#14940

@khufu-dev khufu-dev self-assigned this Sep 3, 2026
@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 23ce0d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
autotest Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T01:45:14.264773Z 626336c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 626336cede

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/autoTest/src/runtime/puppeteerRunner.ts
Base automatically changed from ss/git-ignore to main September 3, 2026 23:26
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
webspatial-sdk-stable Ignored Ignored Preview Sep 4, 2026 6:17pm UTC

Request Review

Puppeteer removed the networkidle options from setContent which never
actually worked puppeteer/puppeteer#14940
@khufu-dev
khufu-dev merged commit a03e8ff into main Sep 4, 2026
12 checks passed
@khufu-dev
khufu-dev deleted the ss/fix-puppeteer branch September 4, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants