Skip to content

fix: Jump links don't work in preview after first click#4714

Merged
istarkov merged 1 commit intomainfrom
page-hash
Jan 5, 2025
Merged

fix: Jump links don't work in preview after first click#4714
istarkov merged 1 commit intomainfrom
page-hash

Conversation

@istarkov
Copy link
Contributor

@istarkov istarkov commented Jan 4, 2025

Description

closes #4691

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov merged commit 88d4aec into main Jan 5, 2025
7 checks passed
@istarkov istarkov deleted the page-hash branch January 5, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jump links don't work in preview after first click

1 participant