Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/builder/app/builder/features/address-bar.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ $pages.set({
const $selectedPageSystem = computed(
[$selectedPage, $dataSourceVariables],
(selectedPage, dataSourceVariables) => {
if (selectedPage === undefined) {
if (selectedPage?.systemDataSourceId === undefined) {
return {};
}
return dataSourceVariables.get(selectedPage.systemDataSourceId);
Expand Down
2 changes: 1 addition & 1 deletion apps/builder/app/builder/features/address-bar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const $selectedPagePath = computed([$selectedPage, $pages], (page, pages) => {
const $selectedPagePathParams = computed(
[$selectedPageDefaultSystem, $selectedPage, $dataSourceVariables],
(defaultSystem, selectedPage, dataSourceVariables) => {
if (selectedPage === undefined) {
if (selectedPage?.systemDataSourceId === undefined) {
return defaultSystem.params;
}
const system = dataSourceVariables.get(selectedPage.systemDataSourceId) as
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ const $hiddenDataSourceIds = computed(
dataSourceIds.add(dataSource.id);
}
}
if (page && isFeatureEnabled("filters")) {
if (page?.systemDataSourceId && isFeatureEnabled("filters")) {
dataSourceIds.delete(page.systemDataSourceId);
}
return dataSourceIds;
Expand Down
2 changes: 1 addition & 1 deletion apps/builder/app/canvas/interceptor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const getSelectedPagePathname = () => {
const pages = $pages.get();
const page = $selectedPage.get();
const dataSourceVariables = $dataSourceVariables.get();
if (page && pages) {
if (page?.systemDataSourceId && pages) {
const system = dataSourceVariables.get(page.systemDataSourceId) as
| undefined
| System;
Expand Down
3 changes: 3 additions & 0 deletions apps/builder/app/shared/nano-states/variables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ export const mergeSystem = (left: System, right?: System): System => {
};

export const updateSystem = (page: Page, update: Partial<System>) => {
if (page.systemDataSourceId === undefined) {
return;
}
const dataSourceVariables = new Map($dataSourceVariables.get());
const system = dataSourceVariables.get(page.systemDataSourceId) as
| undefined
Expand Down
3 changes: 2 additions & 1 deletion apps/builder/app/shared/page-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export const insertPageCopyMutable = ({
const newRootInstanceId =
newInstanceIds.get(page.rootInstanceId) ?? page.rootInstanceId;
const newSystemDataSourceId =
newDataSourceIds.get(page.systemDataSourceId) ?? page.systemDataSourceId;
newDataSourceIds.get(page.systemDataSourceId ?? "") ??
page.systemDataSourceId;
const newPage: Page = {
...page,
id: newPageId,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/react-router-docker/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/react-router-netlify/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/react-router-vercel/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/ssg/app/__generated__/[another-page]._index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/ssg/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fixtures/webstudio-features/app/__generated__/_index.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion packages/cli/src/prebuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ import {
replaceFormActionsWithResources,
isCoreComponent,
coreMetas,
SYSTEM_VARIABLE_ID,
} from "@webstudio-is/sdk";
import type { Data } from "@webstudio-is/http-client";
import { LOCAL_DATA_FILE } from "./config";
Expand Down Expand Up @@ -584,12 +585,19 @@ export const prebuild = async (options: {
rootInstanceId,
parameters: [
{
id: `system`,
id: `page-system`,
instanceId: "",
name: "system",
type: "parameter",
value: pageData.page.systemDataSourceId ?? "",
},
{
id: "global-system",
type: "parameter",
instanceId: "",
name: "system",
value: SYSTEM_VARIABLE_ID,
},
],
instances,
props,
Expand Down
Loading
Loading