fix(devcontainer): Fix pnpm installation issue in postinstall.sh #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istarkov
approved these changes
Feb 23, 2025
|
Thank you!!!! |
istarkov
pushed a commit
that referenced
this pull request
Feb 23, 2025
## Description 1. What is this PR about (link the issue and add a short description) * This PR fixes an issue where `pnpm` was not being correctly installed or configured within the Devcontainer environment when using `postinstall.sh`. * This was causing errors during container startup and when running `pnpm` commands inside the Devcontainer. * The fix ensures `pnpm` is properly set up in `postinstall.sh`, resolving the Devcontainer setup issue. ## Steps for reproduction 1. Start the Webstudio Devcontainer. 2. Expect the Devcontainer to start successfully without `pnpm` related errors. 3. Verify that `pnpm` commands can be executed correctly within the Devcontainer terminal (e.g., `pnpm --version`). ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [x] made a self-review - [x] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [x] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pnpmwas not being correctly installed or configured within the Devcontainer environment when usingpostinstall.sh.pnpmcommands inside the Devcontainer.pnpmis properly set up inpostinstall.sh, resolving the Devcontainer setup issue.Steps for reproduction
pnpmrelated errors.pnpmcommands can be executed correctly within the Devcontainer terminal (e.g.,pnpm --version).Code Review
Before requesting a review
Before merging
.envfile